Comments on: Announcing SitemapGen4j 1.0

By: Lyndon

Lyndon — Mon, 14 Nov 2011 01:14:13 +0000

I know it's naughty but I changed SitemapGenerator from abstract to public abstract which allowed me to do this:
sg = new SitemapGeneratorBuilder(base, outputFolder, Class.forName(sitemapType)).build();

Now by passing in one of the SitemapGenerator's subclasses as sitemapType I have one Spider class, clean code and any type of sitemap I want.

But I would still dearly love to do this properly with the unchanged code.

Any help would be much appreciated.

By: Lyndon

Lyndon — Sun, 13 Nov 2011 16:20:04 +0000

Hi

I have used SitemapGen4J successfully with Arachnid to produce a sitemap.xml. Thanks for such a great piece of code.

What I want to do now is pass a parameter of sitemapType to my spider and it generate the specific type of sitemap file. Eg. Mobile or Web.

I see that the Class SitemapGenerator is abstract and that the specific 'Generator' subclasses extend it.

So, I want to instantiate a specific 'Generator' subclasses but I am confused at how to do this. I am not that good with generics. I see that SitemapGeneratorBuilder does this but I just cannot figure out how to do this.

Any chance of some example of using SitemapGeneratorBuilder to do this would be much appreciated.

By: Tyler

Tyler — Tue, 13 Apr 2010 22:09:27 +0000

The google news sitemap functionality does not support the required elements title and publication (and possible others). This means it is not possible to use your library to create a valid google news sitemap.

The full list of options needs to be added before this the GoogleNewsSitemapGenerator can be used.

By: Dan Fabulich

Dan Fabulich — Wed, 27 Jan 2010 01:04:15 +0000

@Ed, I don’t think I understand your feature. SitemapGen4j actually returns a list of files (since it needs to split the sitemap into multiple files when the sitemap gets too large).

What are you imagining returning to the user? If it just returns the File objects without writing to them, it won’t actually *do* anything (except, perhaps, counting the URLs…?)

By: Dan Fabulich

Dan Fabulich — Wed, 27 Jan 2010 01:00:49 +0000

Unfortunately, we overlooked XML entity-escaping in v1. It’s filed as a bug; I’ll try to get around to it soon.

By: Ed

Ed — Thu, 21 Jan 2010 22:45:04 +0000

Oh yeah — another suggestion for future improvment: Consider a method sig that returns the sitemap File object as opposed to insisting on writing it to disk.

It would enable the avoidance of file i/o when dynamically generating sitemaps.

By: Ed

Ed — Thu, 21 Jan 2010 20:10:17 +0000

Seems like a great tool.

Does it automatically do xml entity-escaping on sitemaps it creates, or is that to be done on our side?

Thanks

By: David

David — Fri, 18 Dec 2009 19:52:10 +0000

I see google have changed the format for News site maps now is this supported? It doesn’t seem to be but I may be mistaken. The details of the new site map format are here http://www.google.com/support/news_pub/bin/answer.py?answer=74288&cbid=sznwmrlbev7e&src=cb&lev=answer

In particluar it seems that an element called publication is required.

By: Greg Georges

Greg Georges — Fri, 23 Oct 2009 13:33:44 +0000

Thanks for your great generator! One thing that I would change though, since we experienced this here, is that in your SitemapGenerator class you use a FileWriter, which by default does not support UTF-8, should change for a FileOutputstream and set the encoding to UTF-8. We had this problem when we saw chinese characters were not written to the file Take care and thans again

By: Raphael Carvalho

Raphael Carvalho — Thu, 10 Sep 2009 13:14:27 +0000

Thanks for explaining that*